Re: [PATCH 1/2] perf: Fix the software events state check

From: Peter Zijlstra
Date: Wed Mar 09 2011 - 08:56:25 EST


On Wed, 2011-03-09 at 14:52 +0100, Frederic Weisbecker wrote:
>
> It seems that ->stop() / ->start() are called from perf_adjust_period()
> to update the hardware with the new settings of period_left. The events
> are stopped to avoid any race with events triggering with a stale period_left
> in the hardware level when the software one has been updated, I guess.
>
> So it doesn't seem to fix any existing bug because for ->stop() and ->start()
> are only useful for hardware events right now. But we may call ->stop() and
> ->start() for further purpose later. In fact that paves the way for the event
> exclusion patchset I'm about to post.
>
> So it should be .39 material. But a confirmation from Peter would be nice.

Yeah, that sounds about right, I've already queued these patches
for .39.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/