Re: [PATCH n_gsm] GSM Mux in non-transparent mode

From: Eric BÃnard
Date: Fri Mar 11 2011 - 08:40:38 EST


Hi MÃrio,

On 10/03/2011 03:39, MÃrio Isidoro wrote:
@@ -2661,9 +2725,12 @@ static int gsmtty_tiocmset(struct tty_struct
*tty, struct file *filp,
struct gsm_dlci *dlci = tty->driver_data;
unsigned int modem_tx = dlci->modem_tx;

- modem_tx &= clear;
+ modem_tx &= ~clear;
modem_tx |= set;

good catch : this fix (and only this one in your patch) makes Telit modems work realiable here with ppp (which was failing before).
Tested on GC864-QUAD-V2, UC864-E and UC864-WD

Thanks !

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/