[PATCH] x86/ce4100: set pci ops via callback instead of module init

From: Sebastian Andrzej Siewior
Date: Fri Mar 11 2011 - 10:22:58 EST


Setting those on subsys initcall will break any x86 platform except
ce4100 which could lead to complains from users.
To avoid those complains, I move to pci.init like others which use the
same kind of quirk.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
---
arch/x86/include/asm/ce4100.h | 6 ++++++
arch/x86/pci/ce4100.c | 5 ++---
arch/x86/platform/ce4100/ce4100.c | 9 +++++++++
3 files changed, 17 insertions(+), 3 deletions(-)
create mode 100644 arch/x86/include/asm/ce4100.h

diff --git a/arch/x86/include/asm/ce4100.h b/arch/x86/include/asm/ce4100.h
new file mode 100644
index 0000000..64db052
--- /dev/null
+++ b/arch/x86/include/asm/ce4100.h
@@ -0,0 +1,6 @@
+#ifndef _ASM_CE4100_H_
+#define _ASM_CE4100_H_
+
+void ce4100_init_pci_ops(void);
+
+#endif
diff --git a/arch/x86/pci/ce4100.c b/arch/x86/pci/ce4100.c
index c63c6d3..8117f72 100644
--- a/arch/x86/pci/ce4100.c
+++ b/arch/x86/pci/ce4100.c
@@ -34,6 +34,7 @@
#include <linux/pci.h>
#include <linux/init.h>

+#include <asm/ce4100.h>
#include <asm/pci_x86.h>

struct sim_reg {
@@ -306,10 +307,8 @@ struct pci_raw_ops ce4100_pci_conf = {
.write = ce4100_conf_write,
};

-static int __init ce4100_pci_init(void)
+void __init ce4100_init_pci_ops(void)
{
init_sim_regs();
raw_pci_ops = &ce4100_pci_conf;
- return 0;
}
-subsys_initcall(ce4100_pci_init);
diff --git a/arch/x86/platform/ce4100/ce4100.c b/arch/x86/platform/ce4100/ce4100.c
index 68c0dbc..93b4e3c 100644
--- a/arch/x86/platform/ce4100/ce4100.c
+++ b/arch/x86/platform/ce4100/ce4100.c
@@ -15,6 +15,7 @@
#include <linux/serial_reg.h>
#include <linux/serial_8250.h>

+#include <asm/ce4100.h>
#include <asm/prom.h>
#include <asm/setup.h>
#include <asm/i8259.h>
@@ -125,6 +126,13 @@ static void __cpuinit sdv_pci_init(void)
}
#endif

+static int __cpuinit ce4100_pci_init(void)
+{
+ ce4100_init_pci_ops();
+ pci_legacy_init();
+ return 0;
+}
+
/*
* CE4100 specific x86_init function overrides and early setup
* calls.
@@ -136,6 +144,7 @@ void __init x86_ce4100_early_setup(void)
x86_init.resources.probe_roms = x86_init_noop;
x86_init.mpparse.get_smp_config = x86_init_uint_noop;
x86_init.mpparse.find_smp_config = x86_init_noop;
+ x86_init.pci.init = ce4100_pci_init;

#ifdef CONFIG_X86_IO_APIC
x86_init.pci.init_irq = sdv_pci_init;
--
1.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/