Re: [PATCH x86/mm] x86-64, NUMA: Don't call numa_set_distanc() forall possible node combinations during emulation

From: Yinghai Lu
Date: Fri Mar 11 2011 - 14:06:35 EST


On 03/11/2011 01:31 AM, Tejun Heo wrote:
> The distance transforming in numa_emulation() used to call
> numa_set_distance() for all MAX_NUMNODES * MAX_NUMNODES node
> combinations regardless of which are enabled. As numa_set_distance()
> ignores all out-of-bound distance settings, this doesn't cause any
> problem other than looping unnecessarily many times during boot.
>
> However, as MAX_NUMNODES * MAX_NUMNODES can be pretty high, update the
> code such that it iterates through only the enabled combinations.
>
> Yinghai Lu identified the issue and provided an initial patch to
> address the issue; however, the patch was incorrect in that it didn't
> build emulated distance table when there's no physical distance table
> and unnecessarily complex.
>
> http://thread.gmane.org/gmane.linux.kernel/1107986/focus=1107988
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Reported-by: Yinghai Lu <yinghai@xxxxxxxxxx>

Acked-by: Yinghai Lu <yinghai@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/