[PATCH] cifssmb: [FIX] warning: âpdataâ may be used uninitialized

From: Richard Genoud
Date: Sun Mar 13 2011 - 12:24:19 EST


This suppress the warning, as far as there's no way pdata is
uninitialized, because validate_ntransact() will initialize pdata or
return rc != 0. In this case (goto qsec_out), pdata won't be used.

Signed-off-by: Richard Genoud <richard.genoud@xxxxxxxxx>
---
fs/cifs/cifssmb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
index 904aa47..efa3f8e 100644
--- a/fs/cifs/cifssmb.c
+++ b/fs/cifs/cifssmb.c
@@ -3138,7 +3138,7 @@ CIFSSMBGetCIFSACL(const int xid, struct cifsTconInfo *tcon, __u16 fid,
__u32 parm_len;
__u32 acl_len;
struct smb_com_ntransact_rsp *pSMBr;
- char *pdata;
+ char *pdata = NULL;

/* validate_nttransact */
rc = validate_ntransact(iov[0].iov_base, (char **)&parm,
--
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/