Re: [PATCH v2 10/12] Introduce CONFIG_GOOGLE_FIRMWARE

From: Mike Waychison
Date: Mon Mar 14 2011 - 16:07:10 EST


On Mon, Mar 14, 2011 at 12:59 PM, Greg KH <greg@xxxxxxxxx> wrote:
> On Mon, Mar 14, 2011 at 12:49:17PM -0700, Mike Waychison wrote:
>> On Mon, Mar 14, 2011 at 8:45 AM, Greg KH <greg@xxxxxxxxx> wrote:
>> > On Fri, Mar 11, 2011 at 05:43:47PM -0800, Mike Waychison wrote:
>> >> In order to keep Google's firmware drivers organized amongst themselves,
>> >> create a new directory for them to live in.  As well, all Google
>> >> firmware drivers are gated on CONFIG_GOOGLE_FIRMWARE=y, which defaults
>> >> to 'n' in the kernel build.
>> >
>> > Everything defaults to 'n' in the kernel build system, so this really
>> > isn't a big deal :)
>>
>> Well, I was hoping that we could have options gating on
>> CONFIG_GOOGLE_FIRMWARE, but default to 'y'.  This makes our lives a
>> bit easier as it means we have a single switch we need to enable on
>> our side and all the options we care about (presumably all
>> google-specific drivers) get enabled.
>>
>> If you have strong objections to this, I can flip the default values
>> of the specific config options to 'n' as well though...
>
> As decreed by Linus and others, all new config options should default to
> 'n', unless your box is going to blow up into tiny pieces if you don't
> select it.

Fair enough.

>
> thanks,
>
> greg k-h
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/