Re: [PATCH] perf: Fix tear-down of inherited group events

[Peter Zijlstra]

On Tue, 2011-03-15 at 12:09 -0400, Vince Weaver wrote:
> On Tue, 15 Mar 2011, Peter Zijlstra wrote:
> 
> > Subject: perf: Fix tear-down of inherited group events
> > From: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> > Date: Tue Mar 15 14:37:10 CET 2011
> > 
> > When destroying inherited events, we need to destroy groups too,
> > otherwise the event iteration in perf_event_exit_task_context() will
> > miss group siblings and we leak events with all the consequences.
> 
> Thanks for the fix!  I can verify that when applied against current 
> linus-git kernel that my original test case no longer leaks memory.
> 
> I've also run the full PAPI regression tests, plus the BLAS/PAPI benchmark 
> code that originally showed the problem and everything checks out fine.
> 
> It's a shame this fix didn't make it in before 2.6.38.

It sure is, sadly there's still only 24h in a day, less if you consider
this .jp earthquake speeding up our planets spin :-)

> Tested-by: Vince Weaver <vweaver1@xxxxxxxxxxxx>

Thanks Vince!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/