Re: Typo in linux-2.6.38/arch/x86/kernel/entry_32.S

From: Eric Valette
Date: Wed Mar 16 2011 - 16:53:40 EST


On 16/03/2011 21:44, Steven Rostedt wrote:
On Wed, 2011-03-16 at 21:32 +0100, Eric Valette wrote:


The old binutils never complained.

Anyway this show once again that the world like symetry and you better
remember it ;-) (lock/unlock, malloc free, ...)

Right, but it should be a warning not an error. If it worked before, why
not work now and just warn about it. This "BUG" existed forever in the
kernel, and its in more than one place. Having the compiler crash on the
first instance means you need to fix it and run the compiler again to
find the next instance and so on.

Yes like any other name change in a .h file with incompatible function signature...

The exact error message is a complaint about the .size directive not being a "constant"...


binutils made a fatal error in making this a bug and not an warning.


Probably a stable candidate for 2.6.38.1

Perhaps, but what about all older kernels. Now this version of binutils
does not work for bisecting.

I guess its binutils git of the 2011/03/02

As far as I'm concerned I only found one occurence on one machine although I compiled tree 2.6.38 kernels for different machines.
because its under the CONFIG_KVM_GUEST flag

--eric


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/