Re: [PATCH] rtc: rtc-ds1390/rtc-ds3234/rtc-m41t94: eliminate compile warning
From: Dennis Aberilla
Date: Wed Mar 16 2011 - 23:05:05 EST
Hi Axel, that doesn't seem to make sense to me since "platform_get_drvdata" is (from include/linux/platform_device.h):
#define platform_get_drvdata(_dev) dev_get_drvdata(&(_dev)->dev)
|Dennis
--- On Thu, 24/2/11, Axel Lin <axel.lin@xxxxxxxxx> wrote:
From: Axel Lin <axel.lin@xxxxxxxxx>
Subject: [PATCH] rtc: rtc-ds1390/rtc-ds3234/rtc-m41t94: eliminate compile warning
To: linux-kernel@xxxxxxxxxxxxxxx
Cc: "Mark Jackson" <mpfj@xxxxxxxxxx>, "Dennis Aberilla" <denzzzhome@xxxxxxxxx>, "Kim B. Heino" <Kim.Heino@xxxxxxxxxxxx>, "Alessandro Zummo" <a.zummo@xxxxxxxxxxxx>, "Thomas Gleixner" <tglx@xxxxxxxxxxxxx>, rtc-linux@xxxxxxxxxxxxxxxx
Received: Thursday, 24 February, 2011, 9:28 AM
Eliminate the following compile warning:
drivers/rtc/rtc-ds1390.c: In function 'ds1390_remove':
drivers/rtc/rtc-ds1390.c:161: warning: passing argument 1 of 'platform_get_drvdata' from incompatible pointer type
drivers/rtc/rtc-ds3234.c: In function 'ds3234_remove':
drivers/rtc/rtc-ds3234.c:161: warning: passing argument 1 of 'platform_get_drvdata' from incompatible pointer type
drivers/rtc/rtc-m41t94.c: In function 'm41t94_remove':
drivers/rtc/rtc-m41t94.c:139: warning: passing argument 1 of 'platform_get_drvdata' from incompatible pointer type
Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
Cc: Mark Jackson <mpfj@xxxxxxxxxx>
Cc: Dennis Aberilla <denzzzhome@xxxxxxxxx>
Cc: Kim B. Heino <Kim.Heino@xxxxxxxxxxxx>
---
drivers/rtc/rtc-ds1390.c | 2 +-
drivers/rtc/rtc-ds3234.c | 2 +-
drivers/rtc/rtc-m41t94.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-ds1390.c b/drivers/rtc/rtc-ds1390.c
index 26a86d2..4832248 100644
--- a/drivers/rtc/rtc-ds1390.c
+++ b/drivers/rtc/rtc-ds1390.c
@@ -158,7 +158,7 @@ static int __devinit ds1390_probe(struct spi_device *spi)
static int __devexit ds1390_remove(struct spi_device *spi)
{
- struct ds1390 *chip = platform_get_drvdata(spi);
+ struct ds1390 *chip = dev_get_drvdata(&spi->dev);
rtc_device_unregister(chip->rtc);
kfree(chip);
diff --git a/drivers/rtc/rtc-ds3234.c b/drivers/rtc/rtc-ds3234.c
index a774ca3..07a558e 100644
--- a/drivers/rtc/rtc-ds3234.c
+++ b/drivers/rtc/rtc-ds3234.c
@@ -158,7 +158,7 @@ static int __devinit ds3234_probe(struct spi_device *spi)
static int __devexit ds3234_remove(struct spi_device *spi)
{
- struct rtc_device *rtc = platform_get_drvdata(spi);
+ struct rtc_device *rtc = dev_get_drvdata(&spi->dev);
rtc_device_unregister(rtc);
return 0;
diff --git a/drivers/rtc/rtc-m41t94.c b/drivers/rtc/rtc-m41t94.c
index c8c97a4..21e6091 100644
--- a/drivers/rtc/rtc-m41t94.c
+++ b/drivers/rtc/rtc-m41t94.c
@@ -136,7 +136,7 @@ static int __devinit m41t94_probe(struct spi_device *spi)
static int __devexit m41t94_remove(struct spi_device *spi)
{
- struct rtc_device *rtc = platform_get_drvdata(spi);
+ struct rtc_device *rtc = dev_get_drvdata(&spi->dev);
if (rtc)
rtc_device_unregister(rtc);
--
1.7.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/