Re: [PATCH 3/4] Check whether pages are poisoned before copying
From: Hidetoshi Seto
Date: Thu Mar 17 2011 - 01:21:15 EST
(2011/03/17 13:14), Andi Kleen wrote:
> On Thu, Mar 17, 2011 at 11:32:55AM +0900, Hidetoshi Seto wrote:
>> So to avoid the above problem, add poison checks for both of 4K pages
>> and the THP before copying in __collapse_huge_page_copy().
> I don't think you need the check for the huge page -- it should not be allocated
> in this case.
Is there no case that the THP is once allocated but poison flag
is set before copy? Though I know it is one of corner cases,
having this check for THP is worse than nothing.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/