Re: [PATCH 2/2] oprofile: Add __exit attibute tooprofile_arch_exit() functions
From: Robert Richter
Date: Thu Mar 17 2011 - 07:41:54 EST
On 16.03.11 16:15:49, Mike Frysinger wrote:
> On Wed, Mar 16, 2011 at 13:58, Robert Richter wrote:
> > 979048e oprofile: don't call arch exit code from init code on failure
> > we may add __exit attibutes to oprofile_arch_exit() functions.
> i dont think this the way to go. how about updating one place
> (include/linux/oprofile.h:oprofile_arch_exit) and making sure all arch
> files are including that header if they arent already ? after all, if
> they arent including that header, the arch code could break without
do you mean we specify the __exit attribute in the function
declaration of the header file and make sure it is included
everythere? I was looking at current implementations in the kernel and
this is not common. Mostly the attributes are set in the function
definition. So I was not sure if that would work. If so, may we skip
then the __exit attribute in the definition?
GCC doc states: "The keyword __attribute__ allows you to specify
special attributes when making a declaration."
but nothing about that happens if it is in the function definition and
this is different from the declaration.
Advanced Micro Devices, Inc.
Operating System Research Center
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/