Re: [PATCH v2] ipv4: netfilter: ipt_CLUSTERIP: fix buffer overflow

From: Changli Gao
Date: Thu Mar 17 2011 - 08:15:48 EST


On Thu, Mar 17, 2011 at 7:32 PM, Vasiliy Kulikov <segoon@xxxxxxxxxxxx> wrote:
> 'buffer' string is copied from userspace.  It is not checked whether it is
> zero terminated.  This may lead to overflow inside of simple_strtoul().
> Changli Gao suggested to copy not more than user supplied 'size' bytes.
>
> It was introduced before the git epoch.  Files "ipt_CLUSTERIP/*" are
> root writable only by default, however, on some setups permissions might be
> relaxed to e.g. network admin user.
>
> Signed-off-by: Vasiliy Kulikov <segoon@xxxxxxxxxxxx>
Acked-by: Changli Gao <xiaosuo@xxxxxxxxx>


--
Regards,
Changli Gao(xiaosuo@xxxxxxxxx)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/