Re: [PATCH v3] Don't update group weights when on service tree.

From: Jens Axboe
Date: Thu Mar 17 2011 - 11:13:54 EST

On 2011-03-17 16:05, Justin TerAvest wrote:
> Version 3 is updated to apply to for-2.6.39/core.
> For version 2, I took Vivek's advice and made sure we update the group
> weight from cfq_group_service_tree_add().
> If a weight was updated while a group is on the service tree, the
> calculation for the total weight of the service tree can be adjusted
> improperly, which either leads to bad service tree weights, or
> potentially crashes (if total_weight becomes 0).
> This patch defers updates to the weight until a group is off the service
> tree.

Thanks, applied. In the future, please remember to prefix the subject
line with the area of interest. This one should be:

cfq-iosched: bla bla bla

so that people going through the log knows what that patch is touching.
I added it for you here.

Jens Axboe

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at