Re: Feedback please: [PATCH] leds: New PCEngines Alix LED driverusing gpio interface
From: Grant Likely
Date: Thu Mar 17 2011 - 14:18:04 EST
On Thu, Mar 17, 2011 at 05:59:06PM +0000, Ed W wrote:
> On 17/03/2011 17:52, Andres Salomon wrote:
> > OLPC stuff lives in arch/x86/platform/olpc; if there was more
> > alix-specific stuff, I'd suggest moving it into something similar.
> > However, I didn't find any. Maybe an arch/x86/platform/geode as a
> > place to collect platform drivers for the various geode-based machines
> > out there (alix, soekris, etc)? Though honestly, I'm not that
> > interested in doing the work to migrate stuff over to there.
> As this is my first stab at this, I think you are agreeing that the
> current change is ok as a first step at least? (I can have a go at a
> larger code re-org later...)
It is actually really easy. You just need to move the file into
arch/x86/platform/geode, add a Makefile, and add a line to
arch/x86/platform/Makefile to include it. In this particular case,
since so much code is sliced out, the patch will actually be easier to
review if the file is moved at the same time.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/