Re: Feedback please: [PATCH] leds: New PCEngines Alix LED driverusing gpio interface

From: Andres Salomon
Date: Thu Mar 17 2011 - 14:22:25 EST

On Thu, 17 Mar 2011 17:59:06 +0000
Ed W <lists@xxxxxxxxxxxxxx> wrote:

> On 17/03/2011 17:52, Andres Salomon wrote:
> > OLPC stuff lives in arch/x86/platform/olpc; if there was more
> > alix-specific stuff, I'd suggest moving it into something similar.
> > However, I didn't find any. Maybe an arch/x86/platform/geode as a
> > place to collect platform drivers for the various geode-based
> > machines out there (alix, soekris, etc)? Though honestly, I'm not
> > that interested in doing the work to migrate stuff over to there.
> As this is my first stab at this, I think you are agreeing that the
> current change is ok as a first step at least? (I can have a go at a
> larger code re-org later...)


> Can I get your final opinion on what should be in the code Copyright
> statement before I resubmit with the module_init change? To recap I
> don't want to alienate anyone, but the code is now based on a)
> leds-5501 and b) a patch from someone not currently credited in the
> file copyright statement? I have stated this origin in the commit
> log and noted the derivation in the code itself. What to do..?

alix_present came from commit
ec9a943ce9f6d6a8ea09587b49d29a020c418c76 , which was from Constantin.
As such, it's probably not a good idea to remove the copyright notice.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at