On Wed, Mar 16, 2011 at 07:23:58PM -0700, adharmap@xxxxxxxxxxxxxx wrote:Add support for GPIO on Qualcomm PM8xxx PMIC chips.
Signed-off-by: Abhijeet Dharmapurikar <adharmap@xxxxxxxxxxxxxx>
Minor points below, but otherwise:
Acked-by: Grant Likely <grant.likely@xxxxxxxxxxxx>
diff --git a/drivers/gpio/pm8xxx-gpio.c b/drivers/gpio/pm8xxx-gpio.c
new file mode 100644
@@ -0,0 +1,455 @@
+/* Copyright (c) 2011, Code Aurora Forum. All rights reserved.
Nit: first line should be '/*' and start the comments on the second
line. It also helps for the first line of the comment block to be a
single line description of what the driver actually is. (a
description, not a filename).
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 and
+ * only version 2 as published by the Free Software Foundation.
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ * Qualcomm PMIC8XXX GPIO driver
Heh, this is the line I just was talking about should appear at the
top of the file. :-)
+static int __init pm_gpio_init(void)
+ int rc = platform_driver_register(&pm_gpio_driver);
+ return rc;