Re: [PATCH] checkpatch: Test for kmalloc/memset(0) pairs

From: Jonathan Corbet
Date: Thu Mar 17 2011 - 23:14:24 EST


On Thu, 17 Mar 2011 22:52:24 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> The use of kzalloc() is preferred over kmalloc/memset(0) pairs.
>
> When a match is made with "memset(p, 0, s);" a search back through the
> patch hunk is made looking for "p = kmalloc(s,". If that is found, then
> a warning is given, suggesting to use kzalloc() instead.

The Coccinelle stuff already has a lot of this kind of test. See, for
example, scripts/coccinelle/api/alloc/kzalloc-simple.cocci. Suppose
there is some way all this nice analysis infrastructure could be
integrated instead of duplicated? Or am I just a crazy dreamer?

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/