RE: [PATCH] AB8500 GPIO : Driver for 42 AB8500 GPIO pins

From: Bibek BASU
Date: Thu Mar 17 2011 - 23:58:13 EST

Hi Grant,

I don't know how the latest patch has not reached you. I am reposting the patch and attaching with this mail also.
Your concern regarding getting gpio irq base address from platform data is addressed in that patch.
Sorry for the confusion.


-----Original Message-----
From: Grant Likely [mailto:glikely@xxxxxxxxxxxx] On Behalf Of Grant Likely
Sent: Friday, March 18, 2011 12:42 AM
To: Linus Walleij
Cc: Bibek BASU; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH] AB8500 GPIO : Driver for 42 AB8500 GPIO pins

On Tue, Mar 15, 2011 at 03:51:09PM +0100, Linus Walleij wrote:
> On Tue, Mar 15, 2011 at 3:33 PM, Grant Likely <grant.likely@xxxxxxxxxxxx> wrote:
> > Ping me *after* Russell's tree gets merged and I'll pick it up.  I
> > don't want to mess about with apply-order breakage.
> This driver does not depend on anything from Russells tree
> or any other tree for that matter... It's a clean merge.

CC drivers/gpio/ab8500-gpio.o
/home/grant/hacking/linux-2.6/drivers/gpio/ab8500-gpio.c: In function 'ab8500_gpio_probe':
/home/grant/hacking/linux-2.6/drivers/gpio/ab8500-gpio.c:432: error: 'MOP500_AB8500_VIR_GPIO_IRQ_BASE' undeclared (first use in this function)
/home/grant/hacking/linux-2.6/drivers/gpio/ab8500-gpio.c:432: error: (Each undeclared identifier is reported only once
/home/grant/hacking/linux-2.6/drivers/gpio/ab8500-gpio.c:432: error: for each function it appears in.)
make[2]: *** [drivers/gpio/ab8500-gpio.o] Error 1
make[1]: *** [drivers/gpio/ab8500-gpio.o] Error 2
make: *** [sub-make] Error 2


$ git grep MOP500_AB8500_VIR_GPIO_IRQ_BASE origin

Looks like I cannot merge this yet.

BTW, why is this driver hardcoding the gpio irq base address instead
of retrieving it from the platform data?


Attachment: 0001-AB8500-GPIO-Board-Support-for-AB8500-GPIO-Driver.patch
Description: 0001-AB8500-GPIO-Board-Support-for-AB8500-GPIO-Driver.patch

Attachment: 0001-AB8500-GPIO-Driver-for-42-AB8500-GPIO-pins.patch
Description: 0001-AB8500-GPIO-Driver-for-42-AB8500-GPIO-pins.patch