Re: [PATCH 1/2 v2] WARN_ON_SMP(): Allow use in if statements on UP

From: Peter Zijlstra
Date: Fri Mar 18 2011 - 05:13:03 EST

On Thu, 2011-03-17 at 17:56 -0400, Steven Rostedt wrote:
> + * WARN_ON(!spin_is_locked(&lock)) checks, as spin_is_locked()
> + * returns 0 for uniprocessor settings.

Arguably most spin_is_locked() usages should be removed in favour of
something like lockdep_assert_held().

The latter only emits code then built with lockdep enabled and it checks
we are indeed the owner, not some random other cpu.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at