Re: [PATCHv4 2/3] ARM: mx51: Implement code to allow mx51 to enter WFI

[Fabio Estevam]

Hi Dinh,

On Fri, Mar 18, 2011 at 12:21 PM,  <Dinh.Nguyen@xxxxxxxxxxxxx> wrote:
...
> + Â Â Â /* Enable NEON SRPG for all but MX50TO1.0. */
> + Â Â Â if (cpu_is_mx51() || cpu_is_mx53())
> + Â Â Â Â Â Â Â __raw_writel(arm_srpgcr, MXC_SRPG_NEON_SRPGCR);

The comment says that NEON SRPG should not be enabled for MX50 TO1.0,
but your code does not check the MX50 silicon revision.

Regards,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/