RE: [PATCHv4 2/3] ARM: mx51: Implement code to allow mx51 to enterWFI

[Nguyen Dinh-R00091]

Hi Fabio,

>-----Original Message-----
>From: Fabio Estevam [mailto:festevam@xxxxxxxxx]
>Sent: Friday, March 18, 2011 10:31 AM
>To: Nguyen Dinh-R00091
>Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
>linux@xxxxxxxxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; u.kleine-
>koenig@xxxxxxxxxxxxxx; arnaud.patard@xxxxxxxxxxx; Vaidyanathan Ranjani-
>RA5478; Zhang Lily-R58066
>Subject: Re: [PATCHv4 2/3] ARM: mx51: Implement code to allow mx51 to
>enter WFI
>
>Hi Dinh,
>
>On Fri, Mar 18, 2011 at 12:21 PM,  <Dinh.Nguyen@xxxxxxxxxxxxx> wrote:
>...
>> + Â Â Â /* Enable NEON SRPG for all but MX50TO1.0. */
>> + Â Â Â if (cpu_is_mx51() || cpu_is_mx53())
>> + Â Â Â Â Â Â Â __raw_writel(arm_srpgcr, MXC_SRPG_NEON_SRPGCR);
>
>The comment says that NEON SRPG should not be enabled for MX50 TO1.0,
>but your code does not check the MX50 silicon revision.

There is no mechanism for checking MX50 Revisions yet. I'll work on adding the MX50 revision check.

Dinh
>
>Regards,
>
>Fabio Estevam

N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ0¶ìh®å’i