Re: [PATCH v8 3/3] cgroups: make procs file writable

From: Paul Menage
Date: Fri Mar 18 2011 - 12:55:11 EST

On Tue, Mar 15, 2011 at 2:13 PM, Ben Blum <bblum@xxxxxxxxxxxxxx> wrote:
> Hmm, you may be right; my understanding of RCU is not complete. But
> actually I think the BUG_ON should just be removed, since we're about to
> drop locks before handing off to cgroup_attach_proc anyway (so at no
> important part is the assertion guaranteed), which will detect and
> EAGAIN if such a race happened.

Sounds good.

> Hmm, well, should I make this assumption, then? The code would not be
> more complicated either way, really. I kind of prefer it as it is...

OK, I guess either way is OK until we can prove otherwise :-)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at