Re: [PATCH] rtc-bfin: add missing "return 0" in new alarm func
From: Mike Frysinger
Date: Fri Mar 18 2011 - 13:52:58 EST
On Fri, Mar 18, 2011 at 10:26, Harry Wei wrote:
> On Fri, Mar 18, 2011 at 04:26:24AM -0400, Mike Frysinger wrote:
>> The new bfin_rtc_alarm_irq_enable function forgot to add a "return 0" to
>> the end leading to the build warning:
>> Â Â Â drivers/rtc/rtc-bfin.c: In function 'bfin_rtc_alarm_irq_enable':
>> Â Â Â drivers/rtc/rtc-bfin.c:253: warning: control reaches end of non-void function
> Â I am sure we should give a return-value
> but whether it is '0'? Maybe it should return
> other value.
> Â Can you give some explanations for yours.
read the interface.c code ... this func returns 0 on "success". i
dont know what other possible value this could return.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/