Re: patch for format issues and header bug in net/ipv4/icmp.c

[David Miller]

From: Ben Hutchings <bhutchings@xxxxxxxxxxxxxx>
Date: Fri, 18 Mar 2011 19:41:01 +0000

> On Sat, 2011-03-19 at 00:05 +0530, Jeffrin Jose wrote:
>> hello ,
>> 
>> I have created a patch for net/ipv4/icmp.c
>> using checkpatch.pl script to fix several warnings
>> and an error.
> 
> You need to learn C programming before trying to correct C programs.
> You should not just do what it takes to make checkpatch.pl happy.

I completely agree, and I absolutely refuse to apply this patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/