Re: [PATCH] r8169: fix a bug in rtl8169_init_phy()

From: Piotr Hosowicz
Date: Sat Mar 19 2011 - 11:52:23 EST

On 19.03.2011 16:41, Oliver Neukum wrote:
Am Samstag, 19. MÃrz 2011, 16:39:11 schrieben Sie:
Le samedi 19 mars 2011 Ã 16:33 +0100, Eric Dumazet a Ãcrit :
Le samedi 19 mars 2011 Ã 16:31 +0100, Oliver Neukum a Ãcrit :
Am Samstag, 19. MÃrz 2011, 16:18:50 schrieb Eric Dumazet:

Problem comes from commit 54405cde762408b00a445466a40da4f7f33a8479
(r8169: support control of advertising.)

Reverting it brings back NIC for me

Odd. It worked for me. Are you testing on a gigabit switch? Could you send
me dmesg? Does it work if you use ethtool to advertise a lower speed?


I found the bug, I am sending a patch in two minutes.

Here it is

[PATCH] r8169: fix a bug in rtl8169_init_phy()

commit 54405cde7624 (r8169: support control of advertising.)
introduced a bug in rtl8169_init_phy()

Thank you. I feel like banging my head against something.

If it will work I will be banging against the wall. I am missing for a fresh new kernel with networking.

Szef TVN24 do dziennikarzy: Kochani, przez dwa lata waliliÅmy w obÃz
rzÄdzÄcy. Tak dalej byc nie moÅe. JesteÅmy telewizjÄ niezaleÅnÄ i to
zobowiÄzuje. Teraz bÄdziemy kopaÄ w opozycjÄ.
NP: Big Big Train - Victorian Brickwork
NB: 2.6.38-git3
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at