Re: [PATCH] r8169: fix a bug in rtl8169_init_phy()

From: Piotr Hosowicz
Date: Sat Mar 19 2011 - 14:59:32 EST

On 19.03.2011 16:39, Eric Dumazet wrote:
Le samedi 19 mars 2011 Ã 16:33 +0100, Eric Dumazet a Ãcrit :
Le samedi 19 mars 2011 Ã 16:31 +0100, Oliver Neukum a Ãcrit :
Am Samstag, 19. MÃrz 2011, 16:18:50 schrieb Eric Dumazet:

Problem comes from commit 54405cde762408b00a445466a40da4f7f33a8479
(r8169: support control of advertising.)

Reverting it brings back NIC for me

Odd. It worked for me. Are you testing on a gigabit switch? Could you send
me dmesg? Does it work if you use ethtool to advertise a lower speed?


I found the bug, I am sending a patch in two minutes.

Here it is

[PATCH] r8169: fix a bug in rtl8169_init_phy()

commit 54405cde7624 (r8169: support control of advertising.)
introduced a bug in rtl8169_init_phy()

Reported-by: Piotr Hosowicz<piotr@xxxxxxxxxxxx>
Signed-off-by: Eric Dumazet<eric.dumazet@xxxxxxxxx>
Cc: Oliver Neukum<oliver@xxxxxxxxxx>
Cc: Francois Romieu<romieu@xxxxxxxxxxxxx>

Tested-by: Piotr Hosowicz<piotr@xxxxxxxxxxxx>

Works OK now.


Piotr Hosowicz

ParafrazujÄc Einsteina: w socjaliÅmie sÄ dwa zawody z przy-
szÅoÅciÄ: piekarz i urzÄdnik, chociaÅ co do pierwszego to
nie mam pewnoÅci. (by Kubarek,
NP: Karmakanic - Send a message from the heart
NB: 2.6.38-20110319-1638-net++
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at