Re: [GIT PULL] First round of SCSI updates for 2.6.38 merge window

From: Geert Uytterhoeven
Date: Sat Mar 19 2011 - 16:00:58 EST


On Thu, Mar 17, 2011 at 21:10, James Bottomley <James.Bottomley@xxxxxxx> wrote:
> This represents the usual round of driver updates (fcoe, lpfc, qla2xxx,
> zfcp, bnx2i, mpt2sas, megaraid_sas, iscsi, cxgbi and hpsa) plus one new
> driver (bnx2fc) and as a bonus we move libsas from the old libata eh to
> the new one paving the way for junking the old one (once we can get ipr
> converted).

> Martin K. Petersen (3):
> Â Â Âsd: Logical Block Provisioning update

drivers/scsi/sd.c: In function âsd_prep_fnâ:
drivers/scsi/sd.c:544: warning: âretâ may be used uninitialized in this function

Actually it's in scsi_setup_discard_cmnd(), which is inlined:

int ret;

[...]

switch (sdkp->provisioning_mode) {

[...]

default:
goto out;
}

[...]

ret = scsi_setup_blk_pc_cmnd(sdp, rq);
rq->buffer = page_address(page);

out:
if (ret != BLKPREP_OK) {

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/