Re: [PATCH 17/20] video: msm: Prevent framebuffer glitch during initialization

From: Sergei Shtylyov
Date: Mon Mar 21 2011 - 09:41:48 EST


Carl Vanderlip wrote:

Holds a reference to the mdp_clk until lateinit, and moves the frambuffer
initialization to device_init.

Maybe I'm just blind but I don't see where the patch does the latter...

The framebuffer lcdc driver will grab a
reference to mdp_clk, which prevents the clock from being disabled by

Dima Zavin <dima@xxxxxxxxxxx>
Rebecca Schultz Zavin <rebecca@xxxxxxxxxxx>
Colin Cross <ccross@xxxxxxxxxxx>

Signed-off-by: Carl Vanderlip <carlv@xxxxxxxxxxxxxx>
drivers/video/msm/mdp.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/drivers/video/msm/mdp.c b/drivers/video/msm/mdp.c
index 0bb19fa..b3f334ad 100644
--- a/drivers/video/msm/mdp.c
+++ b/drivers/video/msm/mdp.c
@@ -38,6 +38,7 @@ struct class *mdp_class;
static DECLARE_WAIT_QUEUE_HEAD(mdp_ppp_waitqueue);
static unsigned int mdp_irq_mask;
+struct clk *mdp_clk_to_disable_later;

Why not just 'mdp_clk'? :-)

WBR, Sergei
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at