[build failure] Re: [GIT PULL] sound updates for 2.6.39-rc1

From: Ingo Molnar
Date: Mon Mar 21 2011 - 11:37:48 EST



* Takashi Iwai <tiwai@xxxxxxx> wrote:

> Linus,
>
> please pull sound updates for v2.6.39-rc1 from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git for-linus

This build failure:

sound/built-in.o: In function `ldo_regulator_remove':
sgtl5000.c:(.text+0x82678): undefined reference to `regulator_unregister'
sound/built-in.o: In function `ldo_regulator_is_enabled':
sgtl5000.c:(.text+0x826c5): undefined reference to `rdev_get_drvdata'
sound/built-in.o: In function `ldo_regulator_disable':
sgtl5000.c:(.text+0x826ef): undefined reference to `rdev_get_drvdata'
sound/built-in.o: In function `ldo_regulator_enable':
sgtl5000.c:(.text+0x82756): undefined reference to `rdev_get_drvdata'
sound/built-in.o: In function `ldo_regulator_get_voltage':
sgtl5000.c:(.text+0x82815): undefined reference to `rdev_get_drvdata'
sound/built-in.o: In function `sgtl5000_probe':

has been pushed upstream - although the build breakage was reported against
linux-next two weeks ago, with fix provided, in this lkml thread:

[PATCH -next] soc: sgtl5000 uses regulator interfaces

Please do not push known-broken code upstream.

Randy's fix below resolved the bug for me.

Thanks,

Ingo

--------------------->