Re: [build failure] Re: [GIT PULL] sound updates for 2.6.39-rc1
From: Mark Brown
Date: Mon Mar 21 2011 - 12:38:55 EST
On Mon, Mar 21, 2011 at 05:11:02PM +0100, Ingo Molnar wrote:
> * Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> > As indicated that's not a good fix since the affected code is all runtime
> > conditional already. [...]
> Well, AFAICS Randy's patch correctly expresses current infrastructure
> dependencies the driver has.
That's because the driver code is trivially broken, though - the build
test has identified a flaw in the driver which we should fix.
> SND_SOC_ALL_CODECS=y but !REGULATOR case, i.e. if it's desirable to have the
> driver build more widely, then that can be enhanced further - but first please
> If it's undesirable to disable the driver in the (unlikely but possible)
> get things to build.
Right, and as I indicated in my reply Zeng said he'd fix this. I'd
rather encourage vendors to take responsibility for their own drivers.
> > [...] It'd be more likely to impede than help the sort of build coverage
> > tests where one would encounter it.
> It's an invariant mostly - both Randy's and my testing will find breakages
> regardless of how restrictively enabled this driver is.
My point is that this is the build test equivalent of using memset to
fix uninitialised variables, it's making the test pass rather than
making things work. When fixing this sort of thing you need to at least
consider if the appropriate fix is to knock out the whole thing in
Kconfig or to make sure the code copes with the dependency set either
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/