[PATCH] sd: Free the page in case of unknown provisioning_mode in scsi_setup_discard_cmnd.

From: Tao Ma
Date: Tue Mar 22 2011 - 00:04:43 EST

From: Tao Ma <boyu.mt@xxxxxxxxxx>

This patch is inspired by a build waring.
drivers/scsi/sd.c:544: warning: â??retâ?? may be used uninitialized in this function

So we need to set a default value to ret here.
But a deep look at scsi_setup_discard_cmnd makes me think
of which value should be set. Now we have BLKPREP_KILL and
BLKPREP_DEFER to indicate an error. As in case of an
unknown sdkp->provisioning_mode, we goto out directly. So
I guess we should return BLKPREP_KILL here and free the page.

Signed-off-by: Tao Ma <boyu.mt@xxxxxxxxxx>
drivers/scsi/sd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 3be5db5..91564bd 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -541,7 +541,7 @@ static int scsi_setup_discard_cmnd(struct scsi_device *sdp, struct request *rq)
sector_t sector = bio->bi_sector;
unsigned int nr_sectors = bio_sectors(bio);
unsigned int len;
- int ret;
+ int ret = BLKPREP_KILL;
char *buf;
struct page *page;


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/