Re: [GIT PULL] First round of SCSI updates for 2.6.38 merge window

From: Martin K. Petersen
Date: Tue Mar 22 2011 - 00:28:30 EST


>>>>> "Geert" == Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> writes:

Geert> drivers/scsi/sd.c: In function âsd_prep_fnâ:
Geert> drivers/scsi/sd.c:544: warning: âretâ may be used uninitialized
Geert> in this function

Sorry about that.


sd: Fail discard requests when logical block provisioning has been disabled

Ensure that we kill discard requests after logical block provisioning
has been disabled in sysfs.

Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 3be5db5..7ff61d7 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -597,6 +597,7 @@ static int scsi_setup_discard_cmnd(struct scsi_device *sdp, struct request *rq)
break;

default:
+ ret = BLKPREP_KILL;
goto out;
}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/