Re: [PATCH 1/5] RFC genirq: Add IRQ timestamping

[torbenh]

On Mon, Mar 21, 2011 at 07:33:26PM -0700, john stultz wrote:
> On Mon, Mar 21, 2011 at 4:59 AM, Torben Hohn <torbenh@xxxxxx> wrote:
> > +       if (desc->status & IRQ_TIMESTAMP)
> > +               getrawmonotonic(&desc->last_timestamp);
> > +
> 
> I suspect you probably want some very clear comments around why you
> chose timestamps based on CLOCK_MONOTONIC_RAW instead of
> CLOCK_MONOTONIC. Likely in the code as well as in the commit log.

I really dont know which clock would be the most useful one.
CLOCK_MONOTONIC_RAW seems to be more suitable to drive dlls.
But the network layer probably wants CLOCK_MONOTONIC or
even CLOCK_REALTIME.

I didnt put much thought in this point, because it requires a broader
discussion, I think.

> 
> thanks
> -john

-- 
torben Hohn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/