Re: [PATCH 1/5] vmscan: remove all_unreclaimable check from direct reclaim path completely
From: KOSAKI Motohiro
Date: Wed Mar 23 2011 - 03:13:30 EST
> Okay. I got it.
> The problem is following as.
> By the race the free_pcppages_bulk and balance_pgdat, it is possible
> zone->all_unreclaimable = 1 and zone->pages_scanned = 0.
> DMA zone have few LRU pages and in case of no-swap and big memory
> pressure, there could be a just a page in inactive file list like your
> example. (anon lru pages isn't important in case of non-swap system)
> In such case, shrink_zones doesn't scan the page at all until priority
> become 0 as get_scan_count does scan >>= priority(it's mostly zero).
if (zone->all_unreclaimable && priority != DEF_PRIORITY)
This tow lines mean, all_unreclaimable prevent priority 0 reclaim.
> And although priority become 0, nr_scan_try_batch returns zero until
> saved pages become 32. So for scanning the page, at least, we need 32
> times iteration of priority 12..0. If system has fork-bomb, it is
> almost livelock.
Therefore, 1000 times get_scan_count(DEF_PRIORITY) takes 1000 times no-op.
> If is is right, how about this?
You seems forgot why you introduced current all_unreclaimable() function.
While hibernation, we can't trust all_unreclaimable.
That's the reason why I proposed following patch when you introduced
mm/vmscan.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index c391c32..1919d8a 100644
@@ -40,6 +40,7 @@
@@ -1931,7 +1932,7 @@ out:
/* top priority shrink_zones still had more to do? don't OOM, then */
- if (scanning_global_lru(sc) && !all_unreclaimable)
+ if (scanning_global_lru(sc) && !all_unreclaimable && !oom_killer_disabled)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/