Re: [PATCH 1/7] char/mei: PCI device and char driver support.
From: Arnd Bergmann
Date: Wed Mar 23 2011 - 03:59:28 EST
On Wednesday 23 March 2011, Alan Cox wrote:
> On Tue, 22 Mar 2011 15:22:59 -0700
> Greg KH <gregkh@xxxxxxx> wrote:
> > On Tue, Mar 22, 2011 at 09:57:59PM +0000, Alan Cox wrote:
> > > > * In the PCI probe function, create a misc character device for
> > > > ". Remove the global
> > > > variables and constants.
> > >
> > > The current code is complex and could be a ton simpler but don't
> > > abuse misc devices when you have one per PCI instance please.
> > The code specifically says it only supports one device in the system at
> > a time. Since it can't do any more than that, why wouldn't it be
> > correct for a misdevice to be used here?
> Arnd was suggesting one device for "every instance you find behind each
> device" so that isn't a good idea for a misc device given there will be
> lots of them.
Yes, makes sense. I was assuming that the common case was that there
is only a single instance.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/