Re: [PATCH 4/4] ACPI: Make sure the FADT is at least rev 2 beforeusing the reset register

From: Matthew Garrett
Date: Wed Mar 23 2011 - 06:59:18 EST


On Wed, Mar 23, 2011 at 12:01:50AM -0400, Len Brown wrote:
> if (!(acpi_gbl_FADT.flags & ACPI_FADT_RESET_REGISTER))
> return;
>
> For it not to be redundant, there would have to be FADTs out there
> of revision 1 that set what was then a reserved bit in the flags.

Yes. You trust them not to have set reserved flags to random garbage?

--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/