Re: [PATCH 1/2] staging: Add ST-Ericsson CG2900 driver
From: Arnd Bergmann
Date: Wed Mar 23 2011 - 10:46:34 EST
On Wednesday 23 March 2011, Par-Gunnar Hjalmdahl wrote:
> + - Decide upon architecture. Some people consider architecture in the cg2900
> + driver to be too complex. We consider it to be not more complex than needed.
> + - Currently the cg2900_uart registers as protocol driver against hci_ldisc.c.
> + There is however some common functionality with hci_h4.c and the cg2900 could
> + therefore register it's vendor specific channels to hci_h4.c, but this would
> + require adding a registration functionality in the hci_h4 file.
> + - Some people demand that the cg2900 driver re-use the Bluetooth driver to send
> + and receive BT commands and events. That is however not possible with current
> + BT API and might not be feasible, for example when using FM only in
> + the cg2900 chip.
> + - TI has already delivered a driver for a multi-function chip called ti-st.
> + This driver is currently located in drivers/misc/ti-st/. There has however
> + been criticism raised against design/architecture of the driver. There
> + currently also doesn't seem to be a way to add support for cg2900 in that
> + driver even though some people has raised this as an alternative.
I assume that this TODO list will evolve a bit as we start resume the
driver. For now, I'm fine this patch going into staging (aside from
my comments on patch 2/2). I'll do a new review soon, please ping me
again if I haven't done it by next week.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/