Re: [RFC] checkpatch: add option to change warning return value.
From: Sarah Sharp
Date: Wed Mar 23 2011 - 14:43:52 EST
On Wed, Mar 23, 2011 at 11:07:07AM +0100, Johannes Weiner wrote:
> On Tue, Mar 22, 2011 at 04:13:10PM -0700, Sarah Sharp wrote:
> > There are a lot of warnings in checkpatch.pl that are rather subjective.
> > For instance, when a line is 81 characters long, and the patch submitter
> > is just cleaning up existing code, a maintainer may not care that
> > checkpatch.pl warns about the over 80-character line. It should be up to
> > the maintainer what warnings they want to pay attention to.
> > Unfortunately, if you try to run checkpatch.pl as part of a git pre-commit
> > hook and a patch in a series being applied by git-am fails checkpatch.pl,
> > the whole process stops. At that point I usually end up just disabling
> > that git hook, which means I don't see real errors in the patches.
> > Add an option to checkpatch.pl to print the warnings, but not return an
> > error code when the --lazy flag is present. (Anyone with a better name
> > can pipe up, lazy just seemed to be the opposite to strict.) This allows
> > the maintainer to view the warnings, but still allow the patch application
> > process to continue.
> I first thought you would add code that allowed turning only select
> errors into warnings.
> If you just want to have git continue in any case, why not append
> '|| true' to the line that invokes checkpatch in your hook script?
Because I still want to stop the patch application process if a true
error was found. I just don't want to stop the patch application
process if just a warning was found.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/