Re: [PATCH] leds: leds-regulator.c, fix handling already enabledregulators

From: Mark Brown
Date: Wed Mar 23 2011 - 17:21:18 EST

On Wed, Mar 23, 2011 at 10:00:02PM +0100, Antonio Ospite wrote:

> The leds-regulator driver was ignoring the initial status of the
> regulator; this resulted in rdev->use_count incremented up to 2 after
> calling regulator_led_set_value() in the .probe method when a regulator
> was already enabled at insmod time, and this made impossible to ever
> disable the regulator.

Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>

> NOTE: initially I thought about CC-ing stable@xxxxxxxxxx as well on
> this, as it is an actual fix, but then I checked that there are
> currently no users of the driver in mainline linux and I dropped it, is
> that how it should be?

Even if there's no users in mainline people could well be shipping out
of tree boards using it and could benefit from the code. OTOH it's not
the most urgent thing ever.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at