Re: [PATCH V12 3/4] ptp: Added a clock driver for the IXP46x.

From: John Stultz
Date: Wed Mar 23 2011 - 17:43:20 EST

On Mon, 2011-02-28 at 08:58 +0100, Richard Cochran wrote:
> This patch adds a driver for the hardware time stamping unit found on the
> IXP465. The basic clock operations and an external trigger are implemented.
> Signed-off-by: Richard Cochran <richard.cochran@xxxxxxxxxx>
> Acked-by: John Stultz <johnstul@xxxxxxxxxx>

My ack is still fine, but found a few more nits to consider on another

> +static int match(struct sk_buff *skb, u16 uid_hi, u32 uid_lo, u16 seq)
> +static void do_rx_timestamp(struct port *port, struct sk_buff *skb)
> +static u64 sys_time_read(struct ixp46x_ts_regs *regs)
> +static void sys_time_write(struct ixp46x_ts_regs *regs, u64 ns)

I know these are static, but these function names are sort of generic
names, and make grep/cscoping for similar sounding functions a little

Maybe add a ipx_ prefix just to be more obvious?


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at