[origin tree build failure] Re: [PATCH] fs, coda: Fix compilewarning when CONFIG_SYSCTL=n.

[Ingo Molnar]

* Rakib Mullick <rakib.mullick@xxxxxxxxx> wrote:

> When CONFIG_SYSCTL=n, we get the following warning:
> 
> fs/coda/sysctl.c:18: warning: âcoda_tableâ defined but not used
> 
> Following patches fixes the above warning by making sure coda_table
> and it's callee
> function are in the same context. It also cleans up the code by
> removing extra #ifdef.
> 
> 
> Signed-off-by: Rakib Mullick <rakib.mullick@xxxxxxxxx>
> ---
> 
> diff --git a/fs/coda/sysctl.c b/fs/coda/sysctl.c
> index c6405ce..d9cc2b3 100644
> --- a/fs/coda/sysctl.c
> +++ b/fs/coda/sysctl.c

FYI, the v2 of this patch:

  0bc825d240ab: codafs: fix compile warning when CONFIG_SYSCTL=n

broke the upstream build:

  fs/built-in.o: In function `init_coda':
  psdev.c:(.init.text+0x2549): undefined reference to `coda_sysctl_clean'
  fs/built-in.o: In function `exit_coda':
  psdev.c:(.exit.text+0x1bf): undefined reference to `coda_sysctl_clean'
  fs/built-in.o: In function `init_coda_psdev':
 psdev.c:(.text.unlikely+0x21e1): undefined reference to `coda_sysctl_init'

I don't think the -v2 commit was build-tested with !CONFIG_PROC_SYSCTL && 
CONFIG_CODA_FS=y.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/