Re: [PATCHv3] usb: core: Change usb_create_sysfs_intf_files()' returntype to void

[Alan Stern]

On Fri, 25 Mar 2011, Michal Nazarewicz wrote:

> The usb_create_sysfs_intf_files() function always returned zero even
> if it failed to create sysfs fails.  Since this is a desired behaviour
> there is no need to return return code at all.  This commit changes
> function's return type (form int) to void.
> 
> Signed-off-by: Michal Nazarewicz <mina86@xxxxxxxxxx>
> Cc: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
> ---
>  drivers/usb/core/sysfs.c |   13 +++++--------
>  drivers/usb/core/usb.c   |    3 +--
>  drivers/usb/core/usb.h   |    2 +-
>  3 files changed, 7 insertions(+), 11 deletions(-)
> 
> On Fri, 25 Mar 2011 16:33:12 +0100, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> > My style preference is to put the empty statement before the comment.
> > It's unusual to have a comment appearing before a statement on the same
> > line.  For example:
> >		;	/* We don't care if the function fails */
> 
> Changed.  And I agree, it looks better now. :)

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/