Re: intel_ips produces constant load of 1

From: Jesse Barnes
Date: Fri Mar 25 2011 - 14:24:54 EST


On Fri, 25 Mar 2011 19:23:15 +0100
Andreas Hartmann <andihartmann@xxxxxxxxxx> wrote:

> Jesse Barnes wrote:
> > On Mon, 21 Mar 2011 11:04:04 -0700
> > Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote:
> >
> >>> ps aux | grep ips
> >>> root 593 0.0 0.0 0 0 ? S 17:20 0:00
> >>> [ips-adjust]
> >>> root 594 0.0 0.0 0 0 ? D 17:20 0:00
> >>> [ips-monitor]
> >>>
> >>> If the module isn't loaded, the load of the machine in idle mode is 0 as
> >>> expected.
> >>
> >> This is a reporting problem, and probably due to the schedule() call
> >> and associated task state in the ips-monitor thread. I thought setting
> >> the task state to interruptible would prevent this, but it seems like
> >> it's not enough for the deferrable on-stack timers?
> >>
> >> At any rate, it's not actually causing increased CPU usage, so you can
> >> safely ignore it until we have a fix.
> >
> > Oops, one task uses interruptible correctly, but the monitor thread
> > doesn't.
> >
> > Does this patch fix your load average?
>
> The patch works fine:
>
> ps aux | grep ips
> root 22427 0.0 0.0 0 0 ? S 19:15 0:00
> [ips-adjust]
> root 22428 0.0 0.0 0 0 ? S 19:15 0:00
> [ips-monitor]

Great, thanks for testing. I'll get the fix over to Matthew.

> btw: what does this mean (first line):
>
>
> kernel: [ 6610.030205] intel ips 0000:00:1f.6: CPU TDP doesn't match
> expected value (found 25, expected 29)

Each SKU has a default TDP. In your case that's 29W. But the BIOS can
override that value with a lower one if the platform (chassis, board,
fans, etc) isn't designed to dissipate the full amount.


--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/