Re: [PATCH] watchdog: fix nv_tco section mismatch

From: Randy Dunlap
Date: Fri Mar 25 2011 - 21:43:19 EST


On 03/25/11 16:42, Mike Waychison wrote:
> On Thu, Mar 24, 2011 at 1:32 PM, Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
>> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>>
>> Fix section mismatch warning:
>> Mark the called nv_tco_getdevice() as __devinit, just like its caller.
>
> This looks fine.
>
> I can't seem to reproduce the warning on my end however, compiling
> this as a built-in nor as a module. How do I trigger a difference
> between __init and __devinit?

I just used allmodconfig. But why wouldn't you see a differnence between
__init and __devinit? They are defined differently in include/linux/init.h,
but maybe on some $arch, those sections are treated differently?

I dunno.

--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/