Re: [PATCH] regulator: fix tps6524x section mismatch

From: Liam Girdwood
Date: Sat Mar 26 2011 - 10:09:27 EST


On Thu, 2011-03-24 at 13:30 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>
> Fix section mismatch that is caused by init code calling exit code:
> pmic_remove() cannot be marked as __devexit.
>
> WARNING: drivers/regulator/tps6524x-regulator.o(.devinit.text+0x205): Section mismatch in reference from the function pmic_probe() to the function .devexit.text:pmic_remove()
> The function __devinit pmic_probe() references
> a function __devexit pmic_remove().
> This is often seen when error handling in the init function
> uses functionality in the exit path.
> The fix is often to remove the __devexit annotation of
> pmic_remove() so it may be used outside an exit section.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> Cc: Liam Girdwood <lrg@xxxxxxxxxxxxxxx>
> Cc: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
> Cc: Cyril Chemparathy <cyril@xxxxxx>
> ---
> drivers/regulator/tps6524x-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Applied.
Thanks

Liam

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/