Re: [PATCH 08/23] fujitsu-laptop: Convert printks to pr_<level>

[Joe Perches]

On Wed, 2011-03-30 at 08:12 +0930, Jonathan Woithe wrote:
> what does pr_*() give us over printk()?
 
Consistency in use of prefix.

> I presume it makes it easier to selectively remove certain
> printk levels from the kernel image in the
> name of size reduction.

That's the goal, but there's no support in the
standard kernel for that yet.

It should also in the future make the prefix a
singleton and remove it from the format string
making the image text a bit smaller.

> Some people *may* insist that these long (>80 character) pr_err() lines be
> split so they remain <80 in length.  This was the reason why the original
> printk() call was split like it was.

I don't.
It makes grepping source for strings easier.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/