Re: [PATCH 09/23] hdaps: Convert printks to pr_<level>

[Lucas De Marchi]

On Tue, Mar 29, 2011 at 19:21, Joe Perches <joe@xxxxxxxxxxx> wrote:
> Added pr_fmt, converted printks and removed
> hard coded prefixes.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
>  drivers/platform/x86/hdaps.c |   19 ++++++++++---------
>  1 files changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/platform/x86/hdaps.c b/drivers/platform/x86/hdaps.c
> index 067bf36..5a34973 100644
> --- a/drivers/platform/x86/hdaps.c
> +++ b/drivers/platform/x86/hdaps.c
> @@ -26,6 +26,8 @@
>  * 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA
>  */
>
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
>  #include <linux/delay.h>
>  #include <linux/platform_device.h>
>  #include <linux/input-polldev.h>
> @@ -238,7 +240,7 @@ static int hdaps_device_init(void)
>                     __check_latch(0x1611, 0x01))
>                goto out;
>
> -       printk(KERN_DEBUG "hdaps: initial latch check good (0x%02x).\n",
> +       printk(KERN_DEBUG "hdaps: initial latch check good (0x%02x)\n",

Shouldn't this be pr_debug() or pr_devel() ?



Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/