Re: [PATCH 07/18] gma500: Add Moorestown backlight support

[Matthew Garrett]

On Wed, Mar 30, 2011 at 10:00:05AM +0100, Alan Cox wrote:

> +	/* Percentage 1-100% being valid */
> +	if (level < 1)
> +		level = 1;

I know you're not actually changing anything here, but opregion supports 
requesting brightnesses between 0 and 255 - it'd be easier if we only 
had one level of scaling, rather than having to map that to a percentage 
only for it to be remapped to the hardware.

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/