Re: [PATCH,RFC] perf: panic due to inclied cpu context task_ctxvalue

[Peter Zijlstra]

On Wed, 2011-03-30 at 17:52 +0200, Oleg Nesterov wrote:
> On 03/30, Peter Zijlstra wrote:
> >
> > On Wed, 2011-03-30 at 17:32 +0200, Oleg Nesterov wrote:
> > > > +#ifdef HAVE_JUMP_LABEL
> > > > +static inline
> > > > +void perf_sched_events_inc(void)
> > > > +{
> > > > +     jump_label_inc(&perf_sched_events_out);
> > > > +     smp_mb__after_atomic_inc();
> > > > +     jump_label_inc(&perf_sched_events_in);
> > > > +}
> > >
> > > probably smp_mb__after_atomic_inc() needs a comment...
> >
> > You don't need it, jump_label_inc() uses atomic_add_return() which
> > implies a full mb.
> 
> Yes, but only if HAVE_JUMP_LABEL.

argh, indeed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/