Re: Merge window closed - 2.6.39-rc1 out

From: Christoph Hellwig
Date: Wed Mar 30 2011 - 18:29:18 EST


(1) it still has the totally stupid interface of a global dispatch table.
Either it does make sense to have different providers, in which
case you want the dispatch table on a per-superblock or whatever
granularity, or you really want just one and can have static calls
into it, and get rid of this whole layer
(2) it still requires totally pointless calls from local filesystem to
initialize a pool ID. The filesystem really should not need to
care about any of this.
(3) it's still lacking a good user submitted with it. And with that
I don't mean junk code shoved into staging where it's bitrotting.

It also has an entirely new bug, in that it assumes every inode has
a dentry on the alias list. Did you only ever test this with filesystem
that do not have export operations? Otherwise the no-dentry case should
be fairly trivial to trigger due the placement of the hooks.

And of course there's still no convincing use case for all of this.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/